Re. ssh-1.2.26 patch for log_msg() overflow (scp fix)

• Previous message: David Dawes: "Re: X11 cookie hijacker"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


Re. ssh-1.2.26 patch for log_msg() overflow:

I wrote:

>I see "va_list args" missing from scp.c; so I copied it from
>similar code in packet.c.

it's been pointed out to me that this is incorrect; try this instead:

diff -u -r  scp.c.patched scp.c
- --- scp.c.patched       Mon Nov  2 23:23:27 1998
+++ scp.c       Mon Nov  2 23:23:42 1998
@@ -333,7 +333,7 @@
   char buf[1024];

   va_start(ap, fmt);
- -  vsnprintf(buf, sizeof(buf), fmt, args);
+  vsnprintf(buf, sizeof(buf), fmt, ap);
   va_end(ap);
   fprintf(stderr, "%s\n", buf);
   exit(255);

apologies

Andrew Daviel

-----BEGIN PGP SIGNATURE-----
Version: PGPfreeware 5.0i for non-commercial use
Charset: noconv

iQA/AwUBNj672VJ35y/HYktJEQJ43QCgsf117UjD/O8YV3sfEZVdE8X3xi0AoMQm
cFi2HYLtUbCeymfQ2PInjjv9
=oVNm
-----END PGP SIGNATURE-----

• Next message: Salvatore Sanfilippo: "Sendmail/Qmail DoS"
• Previous message: David Dawes: "Re: X11 cookie hijacker"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b30 : Fri Apr 13 2001 - 14:21:51 PDT