Re: LSMEXAMPLE.C(.GZ)

gregat_private

On Fri, May 18, 2001 at 10:35:47AM -0400, jmjonesat_private wrote:
> It's still crude, but it does compile, install, and remove correctly.
> I submit it here for ridicule and/or use by anybody who may wish to 
> hack at it.

Some minor suggestions:
	- read Documentation/CodingStyle and modify the file to match
	  the recomendataions found in there.
	- you are going to get confused very quickly using hard coded
	  numbers for the CounterIndex variable.  I suggest using
	  #defines for the numbers.  That way it will be easier to add
	  and subtract elements in the future.
	- what is the magic number 8192 doing in the lsmstats_read
	  function?  Shouldn't you be checking the buffer_length
	  parameter instead?

Other than that looks real nice.  Good work.

greg k-h

_______________________________________________
linux-security-module mailing list
linux-security-moduleat_private
http://mail.wirex.com/mailman/listinfo/linux-security-module