Re: Problems with some of the current hooks

From: David Wagner (dawat_private)
Date: Fri Aug 03 2001 - 15:07:27 PDT

  • Next message: Crispin Cowan: "Re: Making forward progress"

    Stephen Smalley  wrote:
    >+	/* Warning!  The arg parameter may be a user space pointer for some
    >commands.  Handle with care. */
    > 	int (* ioctl)			(struct file *file, unsigned int cmd, unsigned long arg);
    I propose to change this warning to be a bit more clear about what
    care should be taken.  For example: When the arg parameter represents
    a user space pointer, it should never be used.  (Calling copy_from_user()
    on it is definitely right out, as it creates a TOCTTOU vulnerability.)
    linux-security-module mailing list

    This archive was generated by hypermail 2b30 : Fri Aug 03 2001 - 15:47:17 PDT