Re: Problems with some of the current hooks

Previous message: jmjonesat_private: "Re: Making forward progress"
In reply to: Stephen Smalley: "Re: Problems with some of the current hooks"
Next in thread: Stephen Smalley: "Re: Problems with some of the current hooks"
Next in thread: Greg KH: "Re: Problems with some of the current hooks"
Reply: Stephen Smalley: "Re: Problems with some of the current hooks"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

dawat_private

Stephen Smalley  wrote:
>+	/* Warning!  The arg parameter may be a user space pointer for some
>commands.  Handle with care. */
> 	int (* ioctl)			(struct file *file, unsigned int cmd, unsigned long arg);

I propose to change this warning to be a bit more clear about what
care should be taken.  For example: When the arg parameter represents
a user space pointer, it should never be used.  (Calling copy_from_user()
on it is definitely right out, as it creates a TOCTTOU vulnerability.)

_______________________________________________
linux-security-module mailing list
linux-security-moduleat_private
http://mail.wirex.com/mailman/listinfo/linux-security-module