Re: [PATCH] security.h documentation

Previous message: Stephen Smalley: "Re: [PATCH] security.h documentation"
In reply to: Stephen Smalley: "Re: [PATCH] security.h documentation"
Next in thread: Stephen Smalley: "Re: [PATCH] security.h documentation"
Reply: Stephen Smalley: "Re: [PATCH] security.h documentation"
Reply: Stephen Smalley: "Re: [PATCH] security.h documentation"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

gregat_private

On Mon, Sep 10, 2001 at 03:50:44PM -0400, Stephen Smalley wrote:
> 
> I've attached a patch that adds documentation for the struct
> super_block_security_ops hooks and the mount-related hooks
> in the security_operations structure.

Thanks a lot!

> In reviewing these hooks, I noticed that post_addmount is called
> even if the graft_tree call fails.  Should this be changed to only
> call if successful?

I'd think only if it was successful, but no one even checks to see it it
is successful (i.e. the error value isn't returned to the caller).  So
it might not be important.

Anyone using that hook want to speak up?
(actually a lot of changes are happening in the 2.4.10-pre kernel tree
around this chunk of code, but the graft_tree call sequence is still the
same.)

thanks,

greg k-h

_______________________________________________
linux-security-module mailing list
linux-security-moduleat_private
http://mail.wirex.com/mailman/listinfo/linux-security-module