Re: [PATCH] security.h documentation

Previous message: Stephen Smalley: "Re: [PATCH] security.h documentation"
In reply to: Stephen Smalley: "Re: [PATCH] security.h documentation"
Next in thread: Stephen Smalley: "Re: [PATCH] security.h documentation"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

gregat_private

On Mon, Sep 10, 2001 at 04:21:57PM -0400, Stephen Smalley wrote:
> 
> On Mon, 10 Sep 2001, Greg KH wrote:
> 
> > I'd think only if it was successful, but no one even checks to see it it
> > is successful (i.e. the error value isn't returned to the caller).  So
> > it might not be important.
> > 
> > Anyone using that hook want to speak up?
> 
> I'm not sure what you mean.  The return value of graft_tree appears to be
> propagated back all the way from do_add_mount to do_mount to sys_mount to
> the calling process.  We use the post_addmount hook in SELinux, and only
> need it called if the mount was successful.

Doh, so sorry, you are right.
Yes, I think that should be changed to test if graft_tree is successful
or not.  Good catch.

thanks,

greg k-h
(must remember to _always_ look at code before replying to email...)

_______________________________________________
linux-security-module mailing list
linux-security-moduleat_private
http://mail.wirex.com/mailman/listinfo/linux-security-module