Re: [PATCH] add lock hook to prevent race

From: Chris Wright (chrisat_private)
Date: Thu Jan 17 2002 - 22:47:58 PST

  • Next message: Antony Edwards: "Re: [PATCH] add lock hook to prevent race"

    * Antony Edwards (aedwardat_private) wrote:
    > Hi,
    > 
    > This is a patch for consideration. It addresses a race condition detected
    > using the validation tools we (IBM) are working on, and also an
    > inconsistency in the use of the file_ops->lock hook. It is against the
    > 2.5.2 patch. Sorry for the length of the description -- but that's race
    > conditions for you.
    
    Anthony, thanks for the detailed report.  This looks like a good catch.
    I do like making flock() and fcntl() locks funnel through the same hook.
    I realize that copy_from_user can sleep in the fucntions fcntl_[gs]etlk(64),
    but it's not clear to me what could be raceable if that (kernel) interface
    was changed to using the already looked up filp instead of the fd.
    
    any ideas?
    
    thanks,
    -chris
    _______________________________________________
    linux-security-module mailing list
    linux-security-moduleat_private
    http://mail.wirex.com/mailman/listinfo/linux-security-module
    



    This archive was generated by hypermail 2b30 : Thu Jan 17 2002 - 22:42:20 PST