Re: Updated stacker.c (the real one, ignore the last post)

Previous message: dwheelerat_private: "Re: Problem stacking sys_security; need id in security_ops or mod_reg_security"
In reply to: dwheelerat_private: "Updated stacker.c (the real one, ignore the last post)"
Next in thread: dwheelerat_private: "Re: Updated stacker.c (the real one, ignore the last post)"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

gregat_private

Pure code style comment:

> #define COMPUTE_ERROR_IF_ANY_ERROR(CALL) \
> 	int final_result = 0; \
> 	int result; \
> 	struct module_entry *module_p; \
> 	for (module_p = stacked_modules; module_p; module_p->next) { \
> 		result = module_p->module_operations->CALL; \
> 		if (result && !final_result) final_result = result; \
> 	}

You should wrap a  do { ... } while (0) around this and all other code
#defines.  See http://www.kernelnewbies.org/faq/index.php3#dowhile for
why this is a good idea.

I'll try to take a look at the code itself later.

thanks,

greg k-h
_______________________________________________
linux-security-module mailing list
linux-security-moduleat_private
http://mail.wirex.com/mailman/listinfo/linux-security-module