Re: [PATCH] LSM file locking patch is bogus

From: Linus Torvalds (torvaldsat_private)
Date: Sat Jul 27 2002 - 20:13:21 PDT

  • Next message: Crispin Cowan: "Re: Secure Computing statement of assurance"

    On Sat, 27 Jul 2002, Seth Arnold wrote:
    >
    > Matthew, thanks for the patch. However, I'm not sure that the "blocking"
    > field can be removed without opening up some race conditions.
    >
    > Please see the following analysis of the situation by Antony Edwards,
    > and make sure that removing the blocking field is still safe:
    
    This should be a non-issue, since current 2.5.x passes the "struct file"
    pointer around, not the file descriptor. So there should be no race,
    because everybody uses the same "struct file *" everywhere, and nobody
    re-gets the file pointer twice any more.
    
    (Yeah, I'm too lazy to double-check that this is 100% true, but it
    _should_ all have been fixed a few weeks ago).
    
    		Linus
    
    _______________________________________________
    linux-security-module mailing list
    linux-security-moduleat_private
    http://mail.wirex.com/mailman/listinfo/linux-security-module
    



    This archive was generated by hypermail 2b30 : Sat Jul 27 2002 - 20:13:52 PDT