Stephen Smalley wrote: >On Mon, 30 Sep 2002, Chris Wright wrote: > > > >> static void detach_mnt(struct vfsmount *mnt, struct nameidata *old_nd) >> { >>+ /* XXX dcache lock held */ >>+ security_ops->sb_umount_close(mnt); >> >> > >At present, SELinux uses the sb_umount_close() hook to release the > > In the spirit of do_kern_mount vs attach_mnt, sb_umount_close should probably be a separate hook from the detach_mnt hook. But I agree with Chris that a detach_mnt hook is needed for symmetry. So sb_umount_clsoe should remain in do_umount, and detach_mnt should begin with a security_ops->mnt_detach(mnt) or somesuch hook. -serge _______________________________________________ linux-security-module mailing list linux-security-moduleat_private http://mail.wirex.com/mailman/listinfo/linux-security-module
This archive was generated by hypermail 2b30 : Mon Sep 30 2002 - 05:49:23 PDT