Re: graft_tree/attach_mnt rfc

From: Chris Wright (chrisat_private)
Date: Tue Oct 08 2002 - 01:29:56 PDT

  • Next message: Chris Wright: "Re: [patch] [sg]etaffinity hooks"

    * Mike Wray (mike_wrayat_private) wrote:
    > > > BTW, in Serge and Chris's patches moving the sb_post_addmount hook
    > > > from the end of graft_tree() into attach_mount() means that it
    > > > would be called with the dcache_lock held - whereas before
    > > > it wasn't.
    > >
    > > Yes, this is a known side effect.
    > >
    > 
    > This is a problem for us because our present code for handling a mount
    > involves looking up filenames, which will be bad if the dcache_lock is held...
    
    Was Serge's recommendation sufficient?
    
    > > > It also means that sb_post_addmount() might be called
    > > > multiple times on one mount (via copy_tree()).
    > >
    > > This is rather intentional so that recursive bind mounts and
    > > copy_namespace operations get the full picture.
    > 
    > OK, but it means that we don't have a clear idea when a mount is finished -
    > because we can't tell which of the sb_post_addmount() calls is the last.
    > We'd like a hook that is called when the mount is done - so we can do all our
    > work once.
    
    Is this a preference or a true need?
    
    thanks,
    -chris
    
    
    -- 
    Linux Security Modules     http://lsm.immunix.org     http://lsm.bkbits.net
    _______________________________________________
    linux-security-module mailing list
    linux-security-moduleat_private
    http://mail.wirex.com/mailman/listinfo/linux-security-module
    



    This archive was generated by hypermail 2b30 : Tue Oct 08 2002 - 01:39:27 PDT