Re: [RFC] change format of LSM hooks

From: Greg KH (gregat_private)
Date: Wed Oct 16 2002 - 16:46:53 PDT

  • Next message: David S. Miller: "Re: [RFC] change format of LSM hooks"

    On Wed, Oct 16, 2002 at 12:33:50PM -0400, joe perches wrote:
    > On Wed, 2002-10-16 at 14:59, Greg KH wrote:
    > 
    > I think something like:
    > 
    > 	#define check_security(type,args...) security_##type(##args)
    > 
    > would be cleaner and would prefer not collapsing the
    > 
    > 	ret = check_security()
    > 	if (ret)
    > 
    > function use
    
    No, I have to collapse the if and assign lines in order to take
    advantage of the compiler when CONFIG_SERIAL=n.  Then anything within
    the if {} will just be compiled away if the return value of a static
    inline function is 0.
    
    As for using a macro, that doesn't really have any advantages over the
    existing different functions.
    
    thanks,
    
    greg k-h
    _______________________________________________
    linux-security-module mailing list
    linux-security-moduleat_private
    http://mail.wirex.com/mailman/listinfo/linux-security-module
    



    This archive was generated by hypermail 2b30 : Wed Oct 16 2002 - 16:47:35 PDT