Re: [PATCH] LSM changes for 2.5.59

Previous message: Christoph Hellwig: "Re: [BK PATCH] LSM changes for 2.5.59"
In reply to: Greg KH: "[PATCH] LSM changes for 2.5.59"
Next in thread: Christoph Hellwig: "Re: [BK PATCH] LSM changes for 2.5.59"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

hchat_private

On Tue, Feb 04, 2003 at 08:16:11PM -0800, Greg KH wrote:
> diff -Nru a/fs/super.c b/fs/super.c
> --- a/fs/super.c	Wed Feb  5 14:58:37 2003
> +++ b/fs/super.c	Wed Feb  5 14:58:37 2003
> @@ -610,6 +610,7 @@
>  	struct file_system_type *type = get_fs_type(fstype);
>  	struct super_block *sb = ERR_PTR(-ENOMEM);
>  	struct vfsmount *mnt;
> +	int error;
>  
>  	if (!type)
>  		return ERR_PTR(-ENODEV);
> @@ -620,6 +621,13 @@
>  	sb = type->get_sb(type, flags, name, data);
>  	if (IS_ERR(sb))
>  		goto out_mnt;
> + 	error = security_sb_kern_mount(sb);
> + 	if (error) {
> + 		up_write(&sb->s_umount);
> + 		deactivate_super(sb);
> + 		sb = ERR_PTR(error);
> + 		goto out_mnt;
> + 	}

it would be nice if you could follow the syle in this function/file
and put the error handling code out of line.  This is a general
complaint, btw - the LSM hooks seldomly follow the style of the
code around :(

_______________________________________________
linux-security-module mailing list
linux-security-moduleat_private
http://mail.wirex.com/mailman/listinfo/linux-security-module