Re: [PATCH] Process Attribute API for Security Modules 2.5.69

From: viroat_private
Date: Wed May 07 2003 - 03:50:38 PDT

  • Next message: viroat_private: "Re: [PATCH] Change LSM hooks in setxattr 2.5.69" 

    On Tue, May 06, 2003 at 12:13:25PM -0400, Stephen Smalley wrote:
> +static int proc_attr_readdir(struct file * filp,
> +	void * dirent, filldir_t filldir)

Umm...  How about having it merged with proc_base_readdir()?  I.e.
have both call the common helper.  Ditto for lookups.

Other than that (and missing check for copy_to_user() return value in
->read()) I don't see any problems here.
_______________________________________________
linux-security-module mailing list
linux-security-moduleat_private
http://mail.wirex.com/mailman/listinfo/linux-security-module

    This archive was generated by hypermail 2b30 : Wed May 07 2003 - 03:52:27 PDT