On Wed, May 07, 2003 at 11:02:46AM -0400, Stephen Smalley wrote: > On Wed, 2003-05-07 at 06:50, viroat_private > wrote: > > Umm... How about having it merged with proc_base_readdir()? I.e. > > have both call the common helper. Ditto for lookups. > > > > Other than that (and missing check for copy_to_user() return value in > > ->read()) I don't see any problems here. > > This updated patch against 2.5.69 merges the readdir and lookup routines > for proc_base and proc_attr, fixes the copy_to_user call in > proc_attr_read and proc_info_read, moves the new data and code within > CONFIG_SECURITY, and uses ARRAY_SIZE, per the comments from Al Viro and > Andrew Morton. As before, this patch implements a process attribute API > for security modules via a set of nodes in a /proc/pid/attr directory. > Credit for the idea of implementing this API via /proc/pid/attr nodes > goes to Al Viro. Jan Harkes provided a nice cleanup of the > implementation to reduce the code bloat. [snip] Looks sane... - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomoat_private More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ _______________________________________________ linux-security-module mailing list linux-security-moduleat_private http://mail.wirex.com/mailman/listinfo/linux-security-module
This archive was generated by hypermail 2b30 : Fri May 09 2003 - 11:19:01 PDT