Re: [PATCH][LSM] Remove inode_permission_lite hook 3/4

From: Chris Wright (chrisat_private)
Date: Fri Jun 13 2003 - 00:19:08 PDT

  • Next message: Chris Wright: "Re: [PATCH][LSM] setfsuid/setgsuid bug fix 4/4"

    [LSM] Remove security_inode_permission_lite hook
    
    --- linus-2.5/fs/namei.c.perm_lite	Thu Jun 12 22:51:27 2003
    +++ linus-2.5/fs/namei.c	Thu Jun 12 22:51:27 2003
    @@ -325,7 +325,7 @@
     
     	return -EACCES;
     ok:
    -	return security_inode_permission_lite(inode, MAY_EXEC);
    +	return security_inode_permission(inode, MAY_EXEC);
     }
     
     /*
    --- linus-2.5/include/linux/security.h.perm_lite	Thu Jun 12 22:48:12 2003
    +++ linus-2.5/include/linux/security.h	Thu Jun 12 22:51:27 2003
    @@ -327,16 +327,6 @@
      *	@inode contains the inode structure to check.
      *	@mask contains the permission mask.
      *	Return 0 if permission is granted.
    - * @inode_permission_lite:
    - * 	Check permission before accessing an inode.  This hook is
    - * 	currently only called when checking MAY_EXEC access during
    - * 	pathname resolution.  The dcache lock is held and thus modules
    - * 	that could sleep or contend the lock should return -EAGAIN to
    - * 	inform the kernel to drop the lock and try again calling the
    - * 	full permission hook.
    - * 	@inode contains the inode structure to check.
    - * 	@mask contains the permission mask.
    - * 	Return 0 if permission is granted.
      * @inode_setattr:
      *	Check permission before setting file attributes.  Note that the kernel
      *	call to notify_change is performed from several locations, whenever
    @@ -1052,7 +1042,6 @@
     	int (*inode_readlink) (struct dentry *dentry);
     	int (*inode_follow_link) (struct dentry *dentry, struct nameidata *nd);
     	int (*inode_permission) (struct inode *inode, int mask);
    -	int (*inode_permission_lite) (struct inode *inode, int mask);
     	int (*inode_setattr)	(struct dentry *dentry, struct iattr *attr);
     	int (*inode_getattr) (struct vfsmount *mnt, struct dentry *dentry);
             void (*inode_delete) (struct inode *inode);
    @@ -1465,12 +1454,6 @@
     	return security_ops->inode_permission (inode, mask);
     }
     
    -static inline int security_inode_permission_lite (struct inode *inode,
    -						  int mask)
    -{
    -	return security_ops->inode_permission_lite (inode, mask);
    -}
    -
     static inline int security_inode_setattr (struct dentry *dentry,
     					  struct iattr *attr)
     {
    @@ -2096,12 +2079,6 @@
     {
     	return 0;
     }
    -
    -static inline int security_inode_permission_lite (struct inode *inode,
    -						  int mask)
    -{
    -	return 0;
    -}
     
     static inline int security_inode_setattr (struct dentry *dentry,
     					  struct iattr *attr)
    --- linus-2.5/security/dummy.c.perm_lite	Thu Jun 12 22:48:12 2003
    +++ linus-2.5/security/dummy.c	Thu Jun 12 22:51:27 2003
    @@ -308,11 +308,6 @@
     	return 0;
     }
     
    -static int dummy_inode_permission_lite (struct inode *inode, int mask)
    -{
    -	return 0;
    -}
    -
     static int dummy_inode_setattr (struct dentry *dentry, struct iattr *iattr)
     {
     	return 0;
    @@ -826,7 +821,6 @@
     	set_to_dummy_if_null(ops, inode_readlink);
     	set_to_dummy_if_null(ops, inode_follow_link);
     	set_to_dummy_if_null(ops, inode_permission);
    -	set_to_dummy_if_null(ops, inode_permission_lite);
     	set_to_dummy_if_null(ops, inode_setattr);
     	set_to_dummy_if_null(ops, inode_getattr);
     	set_to_dummy_if_null(ops, inode_delete);
    _______________________________________________
    linux-security-module mailing list
    linux-security-moduleat_private
    http://mail.wirex.com/mailman/listinfo/linux-security-module
    



    This archive was generated by hypermail 2b30 : Fri Jun 13 2003 - 00:19:53 PDT