Re: PROBLEM: A Capability LSM Module serious bug

From: Valdis.Kletnieks@private
Date: Mon Dec 08 2003 - 10:05:27 PST

  • Next message: Chris Wright: "Re: PROBLEM: A Capability LSM Module serious bug" 

    On Mon, 08 Dec 2003 12:48:21 EST, "Serge E. Hallyn" said:
> In the following:
> 
> +       task->keep_capabilities = 0;
> +
> +       if ((task->uid && task->euid && task->suid) && !task->keep_capabilities)
> +               cap_clear (task->cap_permitted);
> +       else
> +               task->cap_permitted = CAP_INIT_EFF_SET;
> 
> The check for (!task_keep_capabilities) can be safely removed, right?

I'm tempted to say leave it in, because every 6 weeks I hear somebody mumbling
about actually making capabilities useful/workable, so that '= 0'
initialization may evaporate.  A smart optimizer should be able to prune it out
on its own...

    This archive was generated by hypermail 2b30 : Mon Dec 08 2003 - 10:06:46 PST