Re: Wonkiness in SElinux logging?

From: James Morris (jmorris@private)
Date: Sat Jan 03 2004 - 06:53:13 PST

  • Next message: Valdis.Kletnieks@private: "Re: Wonkiness in SElinux logging?" 

    On Wed, 31 Dec 2003 Valdis.Kletnieks@private wrote:

> Seen in the 2.6.1-rc1-mm1 kernel, in security/selinux/avc.c:
> 
> in avc_audit(), near line 531:
> 
>         /* prevent overlapping printks */
>         spin_lock_irqsave(&avc_log_lock,flags);
> 
>         printk("%s\n", avc_level_string);
>         printk("%savc:  %s ", avc_level_string, denied ? "denied" : "granted");
> 
> What's that first printk doing? It seems to just kick out a blank line:
> 

This will ensure that the log record starts fresh on a new line, and is 
not potentially mixed with a previously unterminated printk.


- James
-- 
James Morris
<jmorris@private>

    This archive was generated by hypermail 2b30 : Sat Jan 03 2004 - 06:54:07 PST