Re: [PATCH] BSD Secure Levels, w/out magicpath

From: Greg KH (greg@private)
Date: Wed Jan 07 2004 - 11:59:20 PST

  • Next message: Michael Halcrow: "Re: [PATCH] BSD Secure Levels, w/out magicpath" 

    On Tue, Jan 06, 2004 at 09:51:01AM -0600, Michael Halcrow wrote:
> On Mon, Jan 05, 2004 at 05:14:35PM -0800, Greg KH wrote:
> > Ob nit pick:  There are a number of lines in your patch that are using
> > spaces instead of tabs...
> 
> Fixed.  Yet another tweak to the .emacs is in order...

More nitpicks:

> +int seclvl_sanity( int reqlvl )

Should be:
> +int seclvl_sanity(int reqlvl)

and:
> +	if( ( reqlvl < -1 ) || ( reqlvl > 2 ) ) {
> +		seclvl_printk( 1, KERN_WARNING, "Attempt to set seclvl out of "
> +			       "range: [%d]\n", reqlvl );

Should be:
> +	if ((reqlvl < -1) || (reqlvl > 2)) {
> +		seclvl_printk(1, KERN_WARNING, "Attempt to set seclvl out of "
> +			      "range: [%d]\n", reqlvl);

(same spacing changes throughout the whole file.)

thanks,

greg k-h

    This archive was generated by hypermail 2b30 : Wed Jan 07 2004 - 12:00:58 PST