Re: [PATCH] BSD Secure Levels LSM (1/1)

From: Greg KH (greg@private)
Date: Thu Aug 05 2004 - 14:50:47 PDT 

On Thu, Aug 05, 2004 at 03:14:50PM -0500, Michael Halcrow wrote:
> +	help
> +	  Implements BSD Secure Levels as an LSM.
> +	  Contact Michael A. Halcrow <mike@private> for support
> +	  on this module.
> +
> +	  If you're unsure, answer N.

How about a pointer to some documentation on how this lsm works, and how
to configure and use it?

> + * Copyright (C) 2001 WireX Communications, Inc <chris@private>
> + * Copyright (C) 2001 Greg Kroah-Hartman <greg@private>
> + * Copyright (C) 2001 Networks Associates Technology, Inc <ssmalley@private>

These need to be all lowercase "(c)" as per the copyright lawyers we
both know and love...

> +struct seclvl_attribute seclvlfs_seclvl_attr = {
> +	.attr = {.owner = THIS_MODULE,.name = "seclvl",
> +		 .mode = S_IFREG | S_IRUGO | S_IWUSR},
> +	.show = seclvl_read_file,
> +	.store = seclvl_write_file,
> +};

Please use the __ATTR macro and friends for creating attributes.  It
makes life easier for you and the other kernel developers in the long
run...

thanks,

greg k-h

This archive was generated by hypermail 2.1.3 : Thu Aug 05 2004 - 14:51:18 PDT