Re: cdrecord deadlocks linux 2.6.8.1 (problem in setscheduler)

From: John Johansen (johansen@private)
Date: Wed Oct 20 2004 - 17:22:57 PDT


On Wed, Oct 20, 2004 at 10:41:24AM -0700, Chris Wright wrote:
> 
> Unfortunately, policy < 0 is not really POSIX compliant, but it's
> documented behaviour, so changing this would change the ABI, and could
> break something.  Otherwise, the simplest would be remove that bit
> altogether.  Don't think we need to hold lock while sampling the value,
> since it should be processor word-sized value, nothing odd on loading
> should happen.  It's possible to loop and recheck, but w/out convincing
> oneself that livelock is not possible, -EPERM and return seems quite
> valid for this very unlikely case.  Untested patch below.
> 

well the patch definately works and is nicer than mine but I'm not sure I
like it just failing, call me a correctness nut (at least for today).  That
being said I'll take it any day over the current behavior :)

jj



This archive was generated by hypermail 2.1.3 : Wed Oct 20 2004 - 17:36:49 PDT