Re: [RFC] [PATCH] Replace security fields with hashtable

From: James Morris (jmorris@private)
Date: Tue Oct 26 2004 - 20:29:22 PDT


On Tue, 26 Oct 2004, Serge E. Hallyn wrote:

> Feedback is much appreciated.

>From what I can tell, this will serialize all LSMs, as well as add 
overhead when probing the hash chains.

IMHO, this code needs to be fully threadable (i.e. no global spinlocks on 
the read side, at least), and also be optimizable for the common case of 
one or two LSMs.

+/* TODO: I'm using semaphore and down_interruptable. Are there
+   any hooks that can be called inside an interrupt where it is NOT
+   possible to sleep on a semaphore?
+*/

Yes, many of the hooks can be called from softirq.  file_send_sigiotask 
can be called from hard irq.


- James
-- 
James Morris
<jmorris@private>



This archive was generated by hypermail 2.1.3 : Tue Oct 26 2004 - 20:29:52 PDT