Re: [PATCH] 4 of 5 IMA: module measurement patch

From: Chris Wright (chrisw@private)
Date: Wed Jun 15 2005 - 15:14:51 PDT

Previous message: Casey Schaufler: "Re: [PATCH] 3 of 5 IMA: LSM-based measurement code"
In reply to: Greg KH: "Re: [PATCH] 4 of 5 IMA: module measurement patch"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]

* Greg KH (greg@private) wrote:
> On Wed, Jun 15, 2005 at 10:57:23AM -0400, Reiner Sailer wrote:
> > +extern int ima_terminating;
> > +extern void measure_kernel_module(void *start, unsigned long len, const char __user *uargs);
> 
> These belong in a .h file somewhere.

Well, I think they _are_ in a .h file (two of them, in fact), it's the
extern keyword that can be and dup declaration that can be dropped.
However, does this thing even compile w/ CONFIG_IMA_MEASURE=n?
Looks quite broken w.r.t. CONFIG_IMA_MEASURE to me.

thanks,
-chris

Previous message: Casey Schaufler: "Re: [PATCH] 3 of 5 IMA: LSM-based measurement code"
In reply to: Greg KH: "Re: [PATCH] 4 of 5 IMA: module measurement patch"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] [ attachment ]

This archive was generated by hypermail 2.1.3 : Wed Jun 15 2005 - 15:15:39 PDT