Re: [PATCH] remove selinux stacked ops

From: Tony Jones (tonyj@private)
Date: Fri Aug 26 2005 - 10:43:19 PDT


On Fri, Aug 26, 2005 at 07:54:55AM -0500, serue@private wrote:
> Quoting Tony Jones (tonyj@private):
> > On Fri, Aug 26, 2005 at 08:29:58AM -0400, Stephen Smalley wrote:
> > > On Fri, 2005-08-26 at 07:58 -0400, Stephen Smalley wrote:
> > > > Ok, as with my prior comment, this one is also invalidated by the fact
> > > > that the static inlines fall back to the cap_ functions if the operation
> > > > is NULL.  So I suppose this would work.
> > > 
> > > Given these changes, what purpose does the capability module and the
> > > CONFIG_SECURITY_CAPABILITIES option serve anymore?  Should capability.c
> > > be removed entirely?
> > 
> > Since stacker will implement every hook (preventing the static inline
> > falling thru) wouldn't retaining capability as a module for composition 
> > be useful?
> 
> For conceptual simplicity I think keeping an actual module for it around
> will be best.  Then other module can either stack with it, or not,
> however they prefer.

The suggestion I just posted to "Re: [PATCH 2/5] Rework stubs in security.h"
would remove any need for capability.c and (should) be stacker friendly.

> Actually that's not quite the way it works under stacker right now.
> If no module is loaded, then dummy is used, but if a module is loaded,

Oh right. You'd think I'd know this :-)

thanks

Tony



This archive was generated by hypermail 2.1.3 : Fri Aug 26 2005 - 10:47:48 PDT