Re: [PATCH] small improvment to some mssql* scripts

• Previous message: Vincent Renardias: "[PATCH] small improvment to some mssql* scripts"
• In reply to: Vincent Renardias: "[PATCH] small improvment to some mssql* scripts"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Wed, Mar 05, 2003 at 06:14:40PM +0100, Vincent Renardias wrote:
> - put duplicate code in a common 'mssql.inc' file.
> - use Nicolas Gregoire's trick to avoid false positives in
> mssqlserver_detect.nasl
> - register service if it's found.

I'm all for it, except :


> + make_sql_login_pkt(username:"Nessus-Test-User", password:crap(20));

Should read :
	sql_packet = make_sql_login_pkt(.....)



In the functions you want to put in mssql.inc, I'd also suggest you
declare the local variables by using local_var first.

FWIW, I'm testing a patch to extend the detection to "Services/unknown",
and I modified the mssql plugins that used to connect to port 1433, so
that they connect to Services/mssql instead.

(testing underway)

				-- Renaud

• Next message: Matt: "kuang2 virus info url change"
• Previous message: Vincent Renardias: "[PATCH] small improvment to some mssql* scripts"
• In reply to: Vincent Renardias: "[PATCH] small improvment to some mssql* scripts"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b30 : Wed Mar 05 2003 - 09:23:08 PST