off by one in pppd

From: david evlis reign (davidreignat_private)
Date: Sat Mar 09 2002 - 20:54:00 PST

  • Next message: Pavel Kankovsky: "Re: compress(vul) + ftpd(?)"

    static int
    setescape(argv)
        char **argv;
    {
        int n, ret;
        char *p, *endp;
    
        p = *argv;
        ret = 1;
        while (*p) {
    	n = strtol(p, &endp, 16);
    	if (p == endp) {
    	    option_error("escape parameter contains invalid hex number '%s'",
    			 p);
    	    return 0;
    	}
    	p = endp;
    	if (n < 0 || n == 0x5E || n > 0xFF) { <--- offending code
    	    option_error("can't escape character 0x%x", n);
    	    ret = 0;
    	} else
    	    xmit_accm[0][n >> 5] |= 1 << (n & 0x1F);
    	while (*p == ',' || *p == ' ')
    	    ++p;
        }
        return ret;
    }
    
    can anyone clarify this?
    
    
    _________________________________________________________________
    Send and receive Hotmail on your mobile device: http://mobile.msn.com
    



    This archive was generated by hypermail 2b30 : Sun Mar 10 2002 - 13:12:52 PST