Re: glibc glob_filename() recurse call stack overflow (Re[2]: Bash Blues )

From: Ali Saifullah Khan (saifullahat_private)
Date: Sun Feb 16 2003 - 01:16:56 PST

  • Next message: spacewalker: "Re: glibc glob_filename() recurse call stack overflow (Re[2]: Bash Blues)" 

    file : bash-VERSION/lib/glob/glob.c
char ** glob_filename(pathname)
char * pathname;
{
.
.
	{
                directory_len = (filename - pathname) + 1;
                directory_name = (char *) alloca (directory_len + 1);

                bcopy (pathname, directory_name, directory_len);
                directory_name[directory_len] = '\0';
                ++filename;
        }
.
.
As Vladimir pointed out, instead of copying a large source string of length
'directory_len' why not simply copy strlen(pathname) bytes to directory_name.
Would this produce a fix ?....I'm not an expert when it comes to C, but so far this is what i conclude.

Regards.

    This archive was generated by hypermail 2b30 : Sun Feb 16 2003 - 10:15:24 PST