Re: LSMEXAMPLE.C(.GZ)

Previous message: jmjonesat_private: "Re: LSMEXAMPLE.C(.GZ)"
In reply to: jmjonesat_private: "LSMEXAMPLE.C(.GZ)"
Reply: jmjonesat_private: "Re: LSMEXAMPLE.C(.GZ)"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

chrisat_private

* jmjonesat_private (jmjonesat_private) wrote:
> 
> It's still crude, but it does compile, install, and remove correctly.
> I submit it here for ridicule and/or use by anybody who may wish to 
> hack at it.

Please do not include modversions.h.  This is no longer approriate, as it is
now handled by Makefiles, and expected to go away by 2.5.

The interface is fairly fluid, and there is no guarantee that new bits will
be added only to the end.  So, as Greg mentioned, you may want to rethink
how you handle your array indexing this (unless this file is automatically
generated from security.h).

Please consider moving to the current paradigm for init_module and
cleanup_module.

static int __init LSM_init(void)
{
	/* stuff from init_module */
}

static void __exit LSM_exit(void)
{
	/* stuff from cleanup_module */
}

module_init(LSM_init);
module_exit(LSM_exit);

Otherwise, looks good ;-)
-chris

_______________________________________________
linux-security-module mailing list
linux-security-moduleat_private
http://mail.wirex.com/mailman/listinfo/linux-security-module