First off, thanks for writing up such in indepth message. And also thanks for the great patch. I only have one small comment: On Fri, Aug 03, 2001 at 04:57:33PM -0400, Stephen Smalley wrote: > @@ -871,7 +877,9 @@ > __free_page(page); > } > > - security_ops->bprm_ops->free_security(&bprm); > + if (bprm.security) > + security_ops->bprm_ops->free_security(&bprm); > + > return retval; > } > This is a bit different from all of the other free_security() calls. Should that just be always a call? And it's up to the security module to guard if it bprm->security is NULL or not, like the other cases. thanks, greg k-h _______________________________________________ linux-security-module mailing list linux-security-moduleat_private http://mail.wirex.com/mailman/listinfo/linux-security-module
This archive was generated by hypermail 2b30 : Fri Aug 03 2001 - 14:13:30 PDT