* frm sdsat_private "08/23/01 11:05:34 -0400" | sed '1,$s/^/* /' * * * On Wed, 22 Aug 2001, richard offer wrote: * *> fixes the signed/unsigned mismatch *> returns -ENOSYS for the default modules (security, capability_plug) *> as requested by Stephen at the BOF. *> Adds a comment to the header file documenting the use of modid and *> the expected behaviour, regarding returning ENOSYS if the module *> does not implement sys_security(). * * IMHO, we should omit the comment from security.h. We can mention it * as an optional convention in separate documentation, along with * documentation of the other hooks. Also, does it really matter * whether modid and call are signed or unsigned? Only for clarity, its a magic number, its not going to be negitive. * The attached * patch is what is currently in my tree. I just added an int magic * parameter and changed the dummy and capability hook functions to * return -ENOSYS. Valdis did make some good points about ENOPKG. But I don't really mind either way, at the BOF I suggested ENOSYS and you IIRC ENOPKG. I don't think its that important which, what I think we'll both agree is that an error code must be returned rather than 0. * * -- * Stephen D. Smalley, NAI Labs richard. ----------------------------------------------------------------------- Richard Offer Technical Lead, Trust Technology, SGI "Specialization is for insects" _______________________________________________________________________ _______________________________________________ linux-security-module mailing list linux-security-moduleat_private http://mail.wirex.com/mailman/listinfo/linux-security-module
This archive was generated by hypermail 2b30 : Thu Aug 23 2001 - 08:53:09 PDT