Re: Bug in acct() hook..

• Previous message: Stephen Smalley: "Initial snapshot release of the LSM-based SELinux prototype"
• In reply to: Lachlan McIlroy: "Bug in acct() hook.."
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Fri, 24 Aug 2001, Lachlan McIlroy wrote:

> If someone executes sys_acct(NULL) and the acct() hook
> returns an error then a NULL file structure will be
> passed to filp_close() which, if I'm not wrong, will
> cause a NULL pointer dereference in the file_count()
> macro.  We could fix it with:
> 
> out_err:
> 	if (file)
> 		filp_close(file, NULL);
> 	goto out;

Good catch.  This looks good to me.

--
Stephen D. Smalley, NAI Labs
ssmalleyat_private





_______________________________________________
linux-security-module mailing list
linux-security-moduleat_private
http://mail.wirex.com/mailman/listinfo/linux-security-module

• Next message: jmjonesat_private: "Newest "reference patch.""
• Previous message: Stephen Smalley: "Initial snapshot release of the LSM-based SELinux prototype"
• In reply to: Lachlan McIlroy: "Bug in acct() hook.."
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b30 : Fri Aug 24 2001 - 06:48:35 PDT