Bug in acct() hook..

Previous message: Greg KH: "Re: [patch] Unix sockets &amp; syscall"
Next in thread: Stephen Smalley: "Re: Bug in acct() hook.."
Reply: Stephen Smalley: "Re: Bug in acct() hook.."
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

lachlanat_private

If someone executes sys_acct(NULL) and the acct() hook
returns an error then a NULL file structure will be
passed to filp_close() which, if I'm not wrong, will
cause a NULL pointer dereference in the file_count()
macro.  We could fix it with:

out_err:
	if (file)
		filp_close(file, NULL);
	goto out;

---
Lachlan McIlroy                    Phone: +61 3 9596 4155
Trusted Linux                        Fax: +61 3 9596 2960
Adacel Technologies Ltd                    www.adacel.com

_______________________________________________
linux-security-module mailing list
linux-security-moduleat_private
http://mail.wirex.com/mailman/listinfo/linux-security-module