Re: [PATCH] settime hooks (1/1)

From: Serge E. Hallyn (serue@private)
Date: Fri Aug 06 2004 - 07:16:05 PDT


> Looks basically fine.  Are you sure you got all callers of
> do_settimeofday?  I'm not sure how the user interfaces the one in
> drivers/acorn/char/i2c.c, for example.

Hi Chris,

I suppose a new audit wouldn't hurt.  At the time (around 2.6.0-pre9?) I
did hit every call to do_settimeofday which did NOT appear to be built-in
timing hardware.  I'm open to discussion about whether we want to impose
LSM controls on such hardware.  Clearly if a timer card can be plugged in
through usb, we'd have a problem, but we don't want an module to prevent a
timer chip from doing its job.

I'll plan to re-check for all do_settimeofday calls next week, and do a
little more research about the ones I'd assumed were timer hw.

thanks,
-serge



This archive was generated by hypermail 2.1.3 : Fri Aug 06 2004 - 07:16:29 PDT